Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve error log when running the dev environment of Console #4983

Merged
merged 1 commit into from
Dec 3, 2023
Merged

fix: resolve error log when running the dev environment of Console #4983

merged 1 commit into from
Dec 3, 2023

Conversation

pillar-cat
Copy link
Contributor

@pillar-cat pillar-cat commented Dec 3, 2023 •
edited by ruibaby
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

This will resolve the error log output when running dev environment of Console

Which issue(s) this PR fixes:

Fixes #4963

Special notes for your reviewer:

Does this PR introduce a user-facing change?

修复开发环境运行 Console 报错的问题

@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. release-note-none Denotes a PR that doesn't merit a release note. labels Dec 3, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from lan-yonghui and wzrove December 3, 2023 08:09
ruibaby
ruibaby approved these changes Dec 3, 2023
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

测试之前需要先删除掉根目录的 node_modules/.vite

@f2c-ci-robot f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2023
guqing
guqing reviewed Dec 3, 2023
View reviewed changes
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 1558f12 into halo-dev:main Dec 3, 2023
2 checks passed
@ruibaby
Copy link
Member

ruibaby commented Dec 3, 2023

/cherrypick release-2.11

@halo-dev-bot halo-dev-bot mentioned this pull request Dec 3, 2023
Merged
@halo-dev-bot
Copy link
Collaborator

@ruibaby: new pull request created: #4984

In response to this:

/cherrypick release-2.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

f2c-ci-robot bot pushed a commit that referenced this pull request Dec 3, 2023
@halo-dev-bot
[release-2.11] fix: resolve error log when running the dev environmen…
5b57245 
…t of Console (#4984)

This is an automated cherry-pick of #4983

/assign ruibaby

```release-note
None
```
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Dec 7, 2023
@JohnNiang JohnNiang added this to the 2.12.x milestone Dec 7, 2023
@JohnNiang JohnNiang modified the milestones: 2.12.x, 2.12.0 Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guqing guqing guqing left review comments

@ruibaby ruibaby ruibaby approved these changes

@lan-yonghui lan-yonghui Awaiting requested review from lan-yonghui

@wzrove wzrove Awaiting requested review from wzrove

Assignees

@guqing guqing

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
2.12.0
Development

Successfully merging this pull request may close these issues.

Dev环境下无法正常运行Console
5 participants
@pillar-cat @ruibaby @halo-dev-bot @guqing @JohnNiang